Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Component/vetting tiny slider #219

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

treighton
Copy link

@treighton treighton commented Jan 30, 2020

Description of the Change

Adding a page for Tiny Slider based on a review to confirm compliance with WCAG 2.1AA

Alternate Designs

I'm not sure that this applies, but the slider was tested in multiple scenarios, manually, in addition to analyzing http://ganlanyuan.github.io/tiny-slider/demo/ (this page is not very accessible), to ensure that there are ways to use the slider accessibly.

Benefits

We will now have an approved slider

Possible Drawbacks

It is still possible to use the slider in an inaccessible way.

This may not be the best solution for use with react since it manipulates the DOM directly.

Verification Process

In order to verify that the slider is accessible, I built a few fake pages that had different instances of the slider in different use cases.

I build one that had just a few slides that were just images, another that had images and text, and another that had links. I tested all of these with controls, and on both autoplay and non-autoplay.

In order to check compliance, I used a combination of Lighthouse accessibility audit, Axe accessibility audit, and manually checking against the WCAG2.1 guidelines https://www.w3.org/TR/WCAG21/ using windows narrator, Mac OS Voiceover, and NVDA screen reader, and manually navigating the pages with only the keyboard.

Checklist:

  • [ x] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] All new and existing tests passed.

Applicable Issues

@treighton treighton marked this pull request as ready for review January 30, 2020 17:41
@timwright12 timwright12 self-assigned this Feb 6, 2020
## Accessibility Notes

- Autoplaying will lead to less than desirable screen reader behavior
- Looping slides will make the "count" listed by screen readers behave abnormally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treighton can you elaborate on "abnormally"?

@jeffpaul
Copy link
Member

@treighton any updates from @timwright12's feedback?

@treighton
Copy link
Author

@jeffpaul I haven't had time to get back into this lately. If i need to bump this up in priority let me know so i can move things around.

@jeffpaul
Copy link
Member

@timwright12 I'll defer to you on optimal timeline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants